Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url attribute to Collection class #1695

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add url attribute to Collection class #1695

merged 2 commits into from
Sep 25, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 25, 2023

Follow-up after #1687. From a comment from @davanstrien:

Would adding a collection_url/url attribute to the Collection object make sense? I realise this can easily be got from the slug i.e. f"https:huggingface.co/collections/{collection.slug}" but maybe it's nice to make it easier for a user to quickly access that so they can check their collection via the Hub more quickly?

@Wauplin Wauplin requested a review from davanstrien September 25, 2023 11:23
@Wauplin Wauplin mentioned this pull request Sep 25, 2023
Merged
7 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 25, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

davanstrien
davanstrien approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@davanstrien davanstrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this so quickly!

src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
@Wauplin @davanstrien
Update src/huggingface_hub/hf_api.py
9dfccc4 
Co-authored-by: Daniel van Strien <[email protected]>
@Wauplin Wauplin merged commit c32d4b3 into main Sep 25, 2023
@Wauplin Wauplin deleted the add-collection-url branch September 25, 2023 11:47
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davanstrien davanstrien davanstrien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wauplin @HuggingFaceDocBuilderDev @davanstrien